A worker with "While Executing" lock and "Reschedule" strategy is rescheduled forever

[bunyan]

Describe the bug
A worker with lock: :while_executing and on_conflict: :reschedule is being rescheduled in a loop after completion.

Expected behavior
Usual Sidekiq worker behaviour, i.e. job being removed from queue after execution.

Current behavior
"Reschedule" strategy runs after the worker code is executed scheduling it to be run again 5 seconds after completion.

Worker class

class Job
  include Sidekiq::Worker

  sidekiq_options lock: :while_executing,
                  lock_timeout: 5, 
                  on_conflict: :reschedule

  def perform
    puts 'hello'
    sleep 1
    puts 'bye'
  end
end

Additional context
I believe the problem is here - whether the strategy will be called or not relies on the result of the callback_safely which by default returns nil. If I add a callback to the worker class like

def after_unlock
  true
end

everything works as expected.

[mhenrixon]

Which version of the gem are you using @bunyan?

[bunyan]

@mhenrixon,
sidekiq-unique-jobs is 7.0.0.beta5
sidekiq is 6.0.1
Ruby version is 2.5.6

[mhenrixon]

I'll get it fixed right away @bunyan

[mhenrixon]

Will be fixed in beta7 @bunyan. Should be released in 10 minutes or so

[bunyan]

Great, thank you @mhenrixon!

[mhenrixon]

Try the new version, now I also have a regression test for it!

[bunyan]

Works fine now with the beta7 👍🏻