Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation incorrect for delete_by_digest #547

Closed
tanner-rutgers opened this issue Oct 30, 2020 · 2 comments
Closed

Documentation incorrect for delete_by_digest #547

tanner-rutgers opened this issue Oct 30, 2020 · 2 comments

Comments

@tanner-rutgers
Copy link
Contributor

Describe the bug
The documentation here says we can call SidekiqUniqueJobs::Digests.delete_by_digest(digest) to clean up dead locks on job death. However, that method appears to be an instance method, not a class method.

Expected behavior
I believe the real call should be SidekiqUniqueJobs::Digests.new.delete_by_digest(digest)

Current behavior
NoMethodError · undefined method `delete_by_digest' for SidekiqUniqueJobs::Digests:Class

Additional context

Version: 7.0.0.beta25

@mhenrixon
Copy link
Owner

I think a convenience class method would be a good idea here but I'll look into it

@mhenrixon
Copy link
Owner

Ok, updating README seems like a better option in this case! done in cffe931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants