Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with unreleased Sidekiq 6.3.0 #636

Closed
teoljungberg opened this issue Sep 8, 2021 · 6 comments
Closed

Compatibility with unreleased Sidekiq 6.3.0 #636

teoljungberg opened this issue Sep 8, 2021 · 6 comments

Comments

@teoljungberg
Copy link

Sidekiq 6.2.2 released an unofficial alias of Sidekiq::Worker as Sidekiq::Job, with the plan to migrate to use Sidekiq::Job going forward after 6.3.0

https://github.com/mperham/sidekiq/blob/237c70fe374142509e031dbbf136d57f43dd4913/lib/sidekiq/job.rb

The old Sidekiq::Job that was inside sidekiq/api has since been renamed to Sidekiq::JobRecord.

@mhenrixon
Copy link
Owner

I'll make the necessary adjustments

@mhenrixon
Copy link
Owner

Released as v7.1.6, I'm considering back-porting it but haven't found the time yet.

@jasonrudolph
Copy link

Released as v7.1.6, I'm considering back-porting it but haven't found the time yet.

Thanks for getting this patched up, @mhenrixon. And thanks for all your work on this gem.

If you have time, a backport for the 6.0.x series would be awesome! 😍

@teoljungberg
Copy link
Author

As sidekiq 6.3.0 hasn't been released yet I haven't given this a whirl, as soon as the release is out I will and then close the issue.

If you @mhenrixon want to do so beforehand, feel free.

@mhenrixon
Copy link
Owner

@teoljungberg actually, it was added already in 6.2.2 which has been released.

@teoljungberg
Copy link
Author

Aye you're correct @mhenrixon. We're running the new naming as of this morning and it works wonders. Thanks for the quick turn around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants