Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent-ruby has dropped support for TimerTask timeouts #697

Closed
ClearlyClaire opened this issue Mar 31, 2022 · 1 comment · Fixed by #688
Closed

concurrent-ruby has dropped support for TimerTask timeouts #697

ClearlyClaire opened this issue Mar 31, 2022 · 1 comment · Fixed by #688

Comments

@ClearlyClaire
Copy link

concurrent-ruby 1.1.10 has dropped support for TimerTask timeouts: ruby-concurrency/concurrent-ruby#926

However, TimerTask timeouts are in use in sidekiq-unique-jobs.

This leads to sidekiq regularly outputting the following in the logs, but beyond that, I don't know what are the exact implications:

TimerTask timeouts are now ignored as these were not able to be implemented correctly

@mhenrixon
Copy link
Owner

Thanks for the report @ClearlyClaire!

I've seen the warnings in one of the projects I am working on. I have some concerns about this since I actually fixed the timeouts to not leak threads so maybe I force a downgrade of concurrent-ruby.

I am afraid that the timeout won't be respected anymore which would really cause problems for people using this gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants