Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning: Use of rpoplpush command in Redis #792

Closed
navidemad opened this issue Jun 16, 2023 · 1 comment
Closed

Deprecation Warning: Use of rpoplpush command in Redis #792

navidemad opened this issue Jun 16, 2023 · 1 comment

Comments

@navidemad
Copy link

Hello, Team,

We appreciate your work on the sidekiq-unique-jobs gem. We've encountered an issue while using version 8.0.2.
We are using :

  • Rails 7.0.5
  • Sidekiq 7.1.2
  • Redis 7.0.11
  • ruby 3.2.2

Describe the bug
During normal operations, we noticed a deprecation warning in our logs related to the use of the rpoplpush command in Redis. Here's the relevant log output:

2023-06-16 12:16:34.050556985 +0200 CEST [worker-1] [sidekiq#5788]
Redis has deprecated the "rpoplpush" command, called at 
["/app/vendor/bundle/ruby/3.2.0/gems/sidekiq-unique-jobs-8.0.2/lib/sidekiq_unique_jobs/locksmith.rb:315:in 'rpoplpush'"]

Since Sidekiq 7.1.0:

Migrate away from all deprecated Redis commands [#5788] Sidekiq will now print a warning if you use one of those deprecated commands.
https://github.com/sidekiq/sidekiq/blob/main/Changes.md#710

Expected behavior
The warning suggests that rpoplpush has been deprecated. According to the Redis documentation (as of the time this issue was created), it is recommended to use the rpop and lpush commands in sequence or use the blpop and rpush commands.

As of Redis version 6.2.0, this command is regarded as deprecated.
It can be replaced by LMOVE with the RIGHT and LEFT arguments when migrating or writing new code.

https://redis.io/commands/rpoplpush/

@mhenrixon
Copy link
Owner

Closed by #781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants