-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support selenium 4.9.x python 3.11 #114
Conversation
Support for latest Selenium version 4.1.0
DeprecationWarning: executable_path has been deprecated, please pass in a Service object
fix Firefox log_path
…ft, test_rightclick_top_left
…eft, test_rightclick_top_left
…om upper left to center
Change version number to 4.0.0 to indicate major revision (of selenium at least) Mark as supporting python 3.11
This is looking really great. I don't know which geckodriver version you are adding here and don't want to run untrusted binaries. So I tried your code with geckodriver 0.33. When I execute
There are also several new deprecation warnings:
|
I would also re-order the imports alphabetically. I'm attaching a patch here. Patch file
|
@tbp105 I'm glad that you find out the issue. |
remove binary drivers (should download them as needed)
ERROR: test_access_attributes_across_iframes (tests.api.test_iframe.IframeTest) Clean up DeprecationWarnings in FF driver. Profile is still deprecated in the selenium driver but part of the helium api so we can't generally fix it without changing the helium api. We can, however, avoid using it unless requested.
Ok, applied the patch, deleted the unused binary (main had already added code to fetch on demand), fixed the test, and cleaned up the warnings. So hopefully it is good now. @petrisorionel It was much easier to find the bug after upgrading selenium and seeing the fix (which, as a side effect, broke the workaround) |
This is basically the same as the MR from @petrisorionel but rebased and updated to selenium 4.9
It also does all of the translations for selenium's redefinition of the origin in the _move_to_element function so consumers of helium don't need to worry about it
The questionable test change you had from the previous MR was actually a bug in selenium that was fixed sometime between then and selenium 4.9 so the (1,1) offset change to the tests was reverted