Window nesting #14
Open
Window nesting #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took a stab at nesting of window elements, which turend out to be quite hard to do. Decided not to use `setParentWindow`, because of limitations on Windows: https://github.com/electron/electron/blob/master/docs/api/browser-window.md#platform-notices This does mean that when nested, windows need to be constructed top down, instead of bottom up, because child windows need the reference of their parent in the constructor. This is not how fiber likes to do things. As a side effect, doing this meant that windows might not be instantiated in their own `finalizeBeforeMount ` phase, which means that adding event handlers must wait untill `commitMount`. I don’t think I have a good enough understanding of fiber to oversee the consequences of moving the event handlers, so any ideas/feedback/comments are very welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at nesting of window elements, which turend out to be quite hard to do.
Decided not to use
setParentWindow, because of limitations on Windows: https://github.com/electron/electron/blob/master/docs/api/browser-window.md#platform-noticesThis does mean that when nested, windows need to be constructed top down, instead of bottom up, because child windows need the reference of their parent in the constructor. This is not how fiber likes to do things.
As a side effect, doing this meant that windows might not be instantiated in their own
finalizeBeforeMountphase, which means that adding event handlers must wait untillcommitMount.I don’t think I have a good enough understanding of fiber to oversee the consequences of moving the event handlers, so any ideas/feedback/comments are very welcome.