Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readdirInclude and readdirExclude should be the same function #36

Closed
mhkeller opened this issue Oct 15, 2015 · 2 comments
Closed

readdirInclude and readdirExclude should be the same function #36

mhkeller opened this issue Oct 15, 2015 · 2 comments

Comments

@mhkeller
Copy link
Owner

With the new idea of passing all options as json, this function should be able to take both include and exclude options. The hard part: what to name it? Candidates:

  • readdir and readdirSync except this is the exact same as fs and so could be confusing
  • readdirMatch and readdirMatchSync is not bad

What do you think @ebrelsford

@mhkeller
Copy link
Owner Author

I think readdirFilter and readdirFilterSync could be good.

@mhkeller
Copy link
Owner Author

This has been implemented in 1.0.0. See changelog for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant