Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to svelte 4 #136

Closed
ghost opened this issue Jun 23, 2023 · 2 comments · Fixed by #137
Closed

Upgrade to svelte 4 #136

ghost opened this issue Jun 23, 2023 · 2 comments · Fixed by #137
Labels
awaiting-merge Finished in a branch, will be included in next release in-progress

Comments

@ghost
Copy link

ghost commented Jun 23, 2023

I upgraded to svelte 4 my project and I have seen that layercake requires svelte 3.

I tried to update your github repo by doing:

pnpm up --latest
pnpm remove eslint-plugin-svelte3
pnpm i eslint-plugin-svelte

After a ´pnpm build´ there are a lot of git changes in the docs folder. I'm not sure on how your repo is set up but probably those files are generated by svelte and now they look different because of svelte 4.

I have a fork here without the changes from pnpm build
https://github.com/MCMattia/layercake

@mhkeller
Copy link
Owner

Yea the docs folder is compiled so I imagine the code will be different. I'll have to go through and make sure there are no breaking changes before putting out a release

@mhkeller
Copy link
Owner

This is pretty much done. Just want to coordinate the publish date with another project.

@mhkeller mhkeller added the awaiting-merge Finished in a branch, will be included in next release label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-merge Finished in a branch, will be included in next release in-progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant