Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspelling in one of the preset options. #394

Closed
kolbdog323 opened this issue Apr 19, 2024 · 6 comments
Closed

Misspelling in one of the preset options. #394

kolbdog323 opened this issue Apr 19, 2024 · 6 comments

Comments

@kolbdog323
Copy link

kolbdog323 commented Apr 19, 2024

Just letting you know you have this spelled wrong Best Audio and Video for MPV. It's suppoed to be MKV not MPV.

@mhogomchungu
Copy link
Owner

Can you post a screenshot that shows the misspelling?

@kolbdog323
Copy link
Author

Here you go:

for online

@mhogomchungu
Copy link
Owner

mhogomchungu commented Apr 19, 2024

You must have added the option yourself, the last part of the code that initially populate the list is below and the problematic entry is not in the code.

{
"options": "-f bestvideo[height=2160][ext=mp4][vcodec^=avc]+bestaudio[ext=m4a]/bestvideo[height=2160]+bestaudio",
"uiName": "Best Audio With Video Resolution Of 2160p",
"website": "Youtube"
},
{
"options": "-f bestvideo[ext=mp4][vcodec^=avc]+bestaudio[ext=m4a]/bestvideo[ext=mp4]+bestaudio[ext=m4a]/bestvideo+bestaudio/best[ext=mp4]/best",
"uiName": "Best Available Audio Video",
"website": "Youtube"
},
{
"options": "-f bestaudio -x --embed-thumbnail --audio-format mp3",
"uiName": "Best Available Audio Only(MP3)",
"website": "Youtube"
},
{
"options": "-f bestaudio -x --embed-thumbnail",
"uiName": "Best Available Audio Only",
"website": "Youtube"
}
])R";
}

@kolbdog323
Copy link
Author

kolbdog323 commented Apr 19, 2024

Nope i have never touched the code once. I wouldn't even know where to fix it manually. Edit: Never mind.

@kolbdog323
Copy link
Author

kolbdog323 commented Apr 19, 2024

I found it and fixed it. Maybe you can add that option in for people who want the best mkv since a lot of times that file size is smaller then the mp4 format. And same quality as the avc version just smaller file size most of the time since it grabs the highest quality webm and m4a.

Here is the code:

"options": "-f bestvideo[ext=webm]+bestaudio[ext=m4a]",
"uiName": "Best Audio and Video for MKV",
"website": "Youtube"

@mhogomchungu
Copy link
Owner

The UI place to add options to the list is at "Configure Tab->Preset Options subtab".

Either you or somebody else added the options and mistyped the entry in the "Ui Name" text field because Media Downloader adds no such entry by itself.

The default list is already too long already and i do not think this addition will add too much value and will just open up a door for others to ask for other default entries that downloads webm by default.

Webm videos are discouraged by default in Media Downloader because they do not work everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants