-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misspelling in one of the preset options. #394
Comments
Can you post a screenshot that shows the misspelling? |
You must have added the option yourself, the last part of the code that initially populate the list is below and the problematic entry is not in the code. media-downloader/src/configure.cpp Lines 1316 to 1337 in 513b8bc
|
Nope i have never touched the code once. I wouldn't even know where to fix it manually. Edit: Never mind. |
I found it and fixed it. Maybe you can add that option in for people who want the best mkv since a lot of times that file size is smaller then the mp4 format. And same quality as the avc version just smaller file size most of the time since it grabs the highest quality webm and m4a. Here is the code: "options": "-f bestvideo[ext=webm]+bestaudio[ext=m4a]", |
The UI place to add options to the list is at "Configure Tab->Preset Options subtab". Either you or somebody else added the options and mistyped the entry in the "Ui Name" text field because Media Downloader adds no such entry by itself. The default list is already too long already and i do not think this addition will add too much value and will just open up a door for others to ask for other default entries that downloads webm by default. Webm videos are discouraged by default in Media Downloader because they do not work everywhere. |
Just letting you know you have this spelled wrong Best Audio and Video for MPV. It's suppoed to be MKV not MPV.
The text was updated successfully, but these errors were encountered: