Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option transform not run #548

Closed
ricaragao opened this issue Jul 31, 2018 · 9 comments
Closed

Option transform not run #548

ricaragao opened this issue Jul 31, 2018 · 9 comments

Comments

@ricaragao
Copy link

ricaragao commented Jul 31, 2018

Hi,

I defined this:
transform: transformEachLine

And my function:

function transformEachLine(value, columnNumber) {
  console.log("test");
  return value;
}

But it not enter in function.

@dboskovic
Copy link
Collaborator

You should be using transform: transformEachLine in this scenario. Was that just a mistype in your example?

@ricaragao
Copy link
Author

My example here was wrong, but in my code is right and not works.

@pokoli
Copy link
Collaborator

pokoli commented Aug 1, 2018

@ricaragao which version are you using? transform was recently implemented so maybe it's not available on your version

@ricaragao
Copy link
Author

v4.1.4

@pokoli
Copy link
Collaborator

pokoli commented Aug 2, 2018

Please update to latest version (4.6.0)

@macarena
Copy link

macarena commented Aug 3, 2018

I have the latest installed and also having problems...
TS can't compile, although if I just ignore the errors, the function seems to work...

Argument of type '{ header: true; dynamicTyping: true; transform: (value: any, col: any) => any; }' is not assignable to parameter of type 'ParseConfig'.
Object literal may only specify known properties, and 'transform' does not exist in type 'ParseConfig'.

captura de tela 2018-08-03 as 01 04 49

@dboskovic
Copy link
Collaborator

We've been discussing the fact that we don't maintain TS definitions at all in #545 - contribute the update to DefinitelyTyped or override the definitions for now.

@3af
Copy link

3af commented Aug 29, 2018

@macarena I updated the TSD so it should compile OK soon.

@pokoli
Copy link
Collaborator

pokoli commented Nov 21, 2018

I'm closing this as I understand the issue has already been fixed. Re-open if you don't agree

@pokoli pokoli closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants