New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serveFile TODO is fixed in http.Dir #1299

Closed

nhooyr opened this issue Dec 18, 2016 · 2 comments

nhooyr commented Dec 18, 2016 •

edited

https://github.com/mholt/caddy/blob/54c63002ccc41e9fd533384a9d87437371bc85df/caddyhttp/staticfiles/fileserver.go#L50

Seems to be fixed at https://github.com/golang/go/blob/aeaa4c3c1da9e7a4afd4152913d6f2bfcf4fad2d/src/net/http/fs.go#L37

Member

mholt commented Dec 27, 2016

Thanks for the heads up @nhooyr --- can you describe how that line resolves the TODO? I'm not seeing it at a glance at least... 😕

Author

nhooyr commented Dec 27, 2016

Ah, I misread, sorry!

nhooyr closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment