Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct import path for filemanager plugins #2211

Merged
merged 1 commit into from
Jul 26, 2018
Merged

fix: correct import path for filemanager plugins #2211

merged 1 commit into from
Jul 26, 2018

Conversation

hacdias
Copy link

@hacdias hacdias commented Jun 27, 2018

That ^ 😄

Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. The CI fail doesn't seem to be because of this change, looks like gofmt needs to be run again @mholt

@mholt
Copy link
Member

mholt commented Jun 28, 2018

Hmmm, I've run it twice. I can't quite figure out why it's failing...

$ gometalinter --disable-all -E vet -E gofmt -E misspell -E ineffassign -E goimports -E deadcode --tests --vendor ./...
caddytls/handshake.go:1::warning: file is not gofmted with -s (gofmt)
caddytls/handshake.go:1::warning: file is not goimported (goimports)
The command "gometalinter --disable-all -E vet -E gofmt -E misspell -E ineffassign -E goimports -E deadcode --tests --vendor ./..." exited with 1.

That file definitely isn't changed in this PR. 😕

@mholt mholt merged commit 06b067b into caddyserver:master Jul 26, 2018
@mholt
Copy link
Member

mholt commented Jul 26, 2018

Thanks for maintaining these, Henrique! We love your plugins. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants