New config option tls.dump_cert #2528
Conversation
This option adds support for dumping auto generated, self-signed certificate into a file in specified path. Signed-off-by: Furkan Mustafa <furkan@rainlab.co.jp>
|
|
There was a problem hiding this comment.
Thanks for the PR!
But... hmm, I think I would like to approach this differently. (Would have been a good idea to open an issue to discuss the implementation first!)
There is an issue where self-signed certs aren't properly served up for sites defined like :2015 because there is no hostname.
I wonder if it would be better to persist a self-signed root cert and then issue for individual hostnames instead.
|
Sorry for sending without discussion first. This was required for my case and worked for me (I'm using my fork). Feel free to close without merge. We(somebody?) can re-introduce with proper planning. Also, I believe that there should also be an option to provide a CA key/cert, for self-signing certificates, so user can just set one CA certificate as trusted, and caddy can just re-issue as many signed certificates as necessary. I guess that'd even (partially) cover for the issue you've mentioned. And that'd also eliminate my need for extracting the issued certificate. |
|
Closing since Caddy 2 approaches this differently. Thanks for the contribution! |
This option adds support for dumping auto generated, self-signed certificate into a file in specified path.
Please let me know if I should improve variable/conf naming, or any part of the code at all.