Merge duplicate struct definitions

[DCRichards]

Where there are multiple properties which reuse the same nested properties, the corresponding struct definition should be flattened. Take the following JSON:

{
   "filter":{
      "sitereference":[
         {
            "value":"shshs"
         }
      ],
      "transactionreference":[
         {
            "value":"3-64-25205"
         }
      ]
   }
}

Expected output:

type AutoGenerated struct {
	Filter Filter `json:"filter"`
}

type FilterAutoGenerated struct {
	Value string `json:"value"`
}

type Filter struct {
	Sitereference        []FilterAutoGenerated `json:"sitereference"`
	Transactionreference []FilterAutoGenerated `json:"transactionreference"`
}

Actual output:

type AutoGenerated struct {
	Filter Filter `json:"filter"`
}

type Sitereference struct {
	Value string `json:"value"`
}

type Transactionreference struct {
	Value string `json:"value"`
}

type Filter struct {
	Sitereference        []Sitereference        `json:"sitereference"`
	Transactionreference []Transactionreference `json:"transactionreference"`
}

[michaelsanford]

I just encountered this and came to file this exact issue.

I'd be willing to take a look (given the tag).

Incidentally, this tool is a boon to anyone using a public API that produces extremely verbose structures. Thank you! ❤️ 🙏

[mholt]

@michaelsanford Yes, would be happy to have your contribution! Thank you!

[Capable-Disk4147]

@michaelsanford Are you still working on this?

[michaelsanford]

@Capable-Disk4147 My gosh, this one slipped under my radar. Many apologies: I am not.

[DCRichards]

I should be able to take a look, but I'm AFK a bit ATM so if someone else is keen then feel free

[emicklei]

I encountered the same problem, here is my simplified example for inspiration.

{
    "dimensionCounts": [
        {
            "label": {
                "de_de": "Mitarbeiter",
                "ja_jp": "\u5F93\u696D\u54E1"
            }
        },
        {
            "label": {
                "fr_fr": "Qualifications",
                "de_de": "Qualifikationen"
            }
        }
    ]
}

DimensionCounts []struct {
	Label struct {
		DeDe string `json:"de_de"`
		JaJp string `json:"ja_jp"`
		FrFr string `json:"fr_fr"`
	} `json:"label,omitempty"`
} `json:"dimensionCounts"`

I will have a look at the code later to see if I can help