Skip to content
This repository has been archived by the owner on Sep 23, 2022. It is now read-only.

Switch from 0.0.13 to 0.0.14 was a breaking change #36

Open
roberkules opened this issue Sep 18, 2018 · 3 comments
Open

Switch from 0.0.13 to 0.0.14 was a breaking change #36

roberkules opened this issue Sep 18, 2018 · 3 comments

Comments

@roberkules
Copy link

I just noticed that our image cropper stopped working after re-deploying the web-app...
the docs don't mention this breaking change, but I can see that the test in tests/dummy/app/components/avatar-cropper.js was updated.

@RobbieTheWagner
Copy link
Collaborator

Hi @roberkules can you please be more specific? I believe the docs are correct, are they not?

@roberkules
Copy link
Author

Hi @rwwagner90,

in the readme / usage example there's this code block:

getCroppedAvatar: function() {
  var container = this.$(this.get('cropperContainer'));
  var croppedImage = container.cropper('getCroppedCanvas');
  this.set('croppedAvatar', croppedImage);
}

but the dependency changed from cropper (0.0.13) to cropperjs (0.0.14). so the jquery-version of cropper isn't used anymore, thus container.cropper fails (there's no $.fn.cropper).

so that's a breaking change and shouldn't be in a patch release, unless I'm missing something.

@RobbieTheWagner
Copy link
Collaborator

@roberkules I was not aware the API changed when moving away from jQuery. Apologies for that! Would you be interested in helping update the examples/docs for anything you see that might be broken?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants