Add metadata to signature

[jfruncek]

Thanks for a great project, I've been using it for a few months now. Below is a simple patch I needed for gathering metadata about the signature image. Hope you can use it.

Index: src/main/java/org/jnbis/api/model/record/SignatureImage.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8

diff --git a/src/main/java/org/jnbis/api/model/record/SignatureImage.java b/src/main/java/org/jnbis/api/model/record/SignatureImage.java
--- a/src/main/java/org/jnbis/api/model/record/SignatureImage.java (revision f5f2178)
+++ b/src/main/java/org/jnbis/api/model/record/SignatureImage.java (revision fdef3ce413c46d149a0e2c32e38f04ed233a44ff)
@@ -7,4 +7,29 @@
*/
public class SignatureImage extends BaseImageRecord {

• private String signatureType, signatureRepresentationType, imageScanningResolution;

• public void setSignatureType(String value) {

•    this.signatureType = value;
  

• }

• public String getSignatureType() {

•    return signatureType;
  

• }

• public void setSignatureRepresentationType(String value) {

•    this.signatureRepresentationType = value;
  

• }

• public String getSignatureRepresentationType() {

•    return signatureRepresentationType;
  

• }

• public void setImageScanningResolution(String valueOf) {

•    this.imageScanningResolution = imageScanningResolution;
  

• }

• public String getImageScanningResolution() {

•    return imageScanningResolution;
  

• }
  }
  Index: src/main/java/org/jnbis/internal/record/reader/SignatureImageReader.java
  IDEA additional info:
  Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
  <+>UTF-8
  ===================================================================
  diff --git a/src/main/java/org/jnbis/internal/record/reader/SignatureImageReader.java b/src/main/java/org/jnbis/internal/record/reader/SignatureImageReader.java
  --- a/src/main/java/org/jnbis/internal/record/reader/SignatureImageReader.java (revision f5f2178)
  +++ b/src/main/java/org/jnbis/internal/record/reader/SignatureImageReader.java (revision fdef3ce413c46d149a0e2c32e38f04ed233a44ff)
  @@ -26,6 +26,30 @@
  dataSize += token.buffer.length - token.pos - 12;
  }

•    //Image designation character (IDC)
  

•    int idc = token.buffer[token.pos + 4];
  

•    signatureImage.setImageDesignationCharacter(String.valueOf(idc));
  

•    //Signature type (SIG)
  

•    int sig = token.buffer[token.pos + 5];
  

•    signatureImage.setSignatureType(String.valueOf(sig));
  

•    //Signature representation type (SRT)
  

•    int srt = token.buffer[token.pos + 6];
  

•    signatureImage.setSignatureRepresentationType(String.valueOf(srt));
  

•    //Image scanning resolution (ISR)
  

•    int isr = token.buffer[token.pos + 7];
  

•    signatureImage.setImageScanningResolution(String.valueOf(isr));
  

•    //Horizontal line length (HLL)
  

•    long hll = read2BytesAsInt(token, 8);
  

•    signatureImage.setHorizontalLineLength(String.valueOf(hll));
  

•    //Vertical line length (VLL)
  

•    long vll = read2BytesAsInt(token, 10);
  

•    signatureImage.setVerticalLineLength(String.valueOf(vll));
  

•    byte[] data = new byte[dataSize];
     System.arraycopy(token.buffer, token.pos + 12, data, 0, data.length + 12 - 12);
  

[mhshams]

thanks @jfruncek , you patch is merged and is available in release 2.1.2