Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App consider gemini links as invalid #14

Closed
anedroid opened this issue May 27, 2022 · 0 comments
Closed

App consider gemini links as invalid #14

anedroid opened this issue May 27, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@anedroid
Copy link

anedroid commented May 27, 2022

Describe the bug
I can't add a bookmark to interesting article that I found in geminispace, because app think this URL is invalid. Gemimi is a web protocol for plaintext-only websites. It has been created in 2019 as an answer to current bloated web where you are tracked everywhere and have no control over how websites look in your browser and what they do. You can read about gemini here:

=> https://gemini.circumlunar.space
=> https://geminiquickst.art

or through Gemimi:

=> gemini://gemini.circumlunar.space
=> gemini://geminiquickst.art

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Bookmarks'
  2. Add new bookmark
  3. Insert any gemimi link into 'URL'
  4. Click 'back' to save bookmarl
  5. Invalid URL

Expected behavior
Bookmark should be added.

Smartphone:

  • Device: any
  • OS: Android 11
  • App Version: 1.0

Additional context
I have checked the source code to know how app validates URLs. It use android.webkit.URLUtil. In fact this tool rejects all URLs that is not http or https. Maybe the solution would be to validate using generic Regex, like /^\w+:\/+/ instead? I am sorry, but I don't know Kotlin nor Android development so I can't make a pull request.

@mhss1 mhss1 added the bug Something isn't working label May 27, 2022
@mhss1 mhss1 added this to Planning in Project roadmap May 27, 2022
@mhss1 mhss1 moved this from Planning to In progress in Project roadmap May 28, 2022
@mhss1 mhss1 mentioned this issue May 28, 2022
11 tasks
@mhss1 mhss1 closed this as completed May 28, 2022
Project roadmap automation moved this from In progress to Done May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants