-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-insiders: Webview contents not loading #317
Comments
Hi @morganlombard, I believe this is being caused by #305 (please read the full thread for more context of this change). Provided this is what's occurring (seems highly likely), I'll have a beta fix available for this soon. |
After making the vscode team aware of this bug, they have implemented a fix to resolve it (as it relates to all extensions that use a Webview). It will hopefully be included in the next vscode-insiders build, which will allow Git Graph to work again in vscode-insiders. |
Same in today's vscode-insiders build. |
"Me too" on OSx:
|
This should be fixed in the next VS Code insiders (I fixed the original bug the caused this yesterday and then proceeded to break it again in an interesting new way!) |
Fixed in
|
Closing this now, as it has been fixed in the latest vscode-insiders build for almost a day now. |
FYI for anyone coming across this issue, seems to have regressed in 1.47.x
|
Yes, experiencing the same problem in the latest insider's build |
@mjbvz The bug described below is preventing all Git Graph users that use Visual Studio Code Insiders from using the extension (and affects all extensions that use Webview's) - it is different from the bug you previously fixed. Here's some additional background information: Starting around Visual Studio Code 1.43.0 (give or take a release), immediately after the vscode release some users intermittently observed that Visual Studio Code would fail to load resources via the vscode-resource scheme. I can also confirm that it occurred using the old direct-set method of vscode-resource, and using the new asWebviewUri method. It has been reported by users on Windows, Mac & Ubuntu (so isn't platform specific). It was fixed for about three weeks, and just a few days ago it started to intermittently affect users. However, in today's insiders build, it seems to not work for everyone, I've got heaps of reports of it. |
NINJA EDIT: Looks like next insiders will have it fixed: microsoft/vscode#100918 (comment) |
@mhutchie latest insiders works again for me in newest 1.47.0-insider released today |
It seems to be broken again in the next Insiders build: Version: 1.47.0-insider (user setup) |
Yep, @mhutchie I can confirm that it's broken again... Version: 1.47.0-insider (user setup) |
I've raised this with Microsoft again, hopefully it will be fixed soon... |
Webviews are now working again in Visual Studio Code Insiders:
|
@mhutchie confirmed working for me, thanks for going to bat with the code team on that one. |
@volopasse I've just tried Git Graph in WSL with the same Visual Studio Code Insiders release as you're using, and everything is working fine for me. I also haven't had any reports of issues since my previous response above. What is the full path of |
@volopasse That's really interesting, it would be great if you could spin up a new WSL and see if it persists. |
Spun up a brand new WSL (Ubuntu 20), same thing, 404's on the two network resources.
But nothing shows up because the resources could not be loaded VSCode Release (with the following build details) loads the same repo correctly. However, the URIs are different: Release version has EDIT: here are the actual build details for a working Release version
|
@volopasse, Thanks for the additional information. I've been experimenting and still can't observe the 404's you're getting in WSL. The team at Microsoft have been been rewriting the Webview implementation this iteration, which has been causing all of the bugs we've had recently in the Visual Studio Code Insiders build. The URI scheme change from Would you mind raising this Visual Studio Code Insiders WSL Webview issue you're observing to the vscode team? With all their Webview changes it seems highly likely that this is a bug that they need to resolve. If it's affecting you using Git Graph, it will likely be affecting others who use WSL and any of the extensions that use Webviews. I'll keep an eye out for it, and will provide additional assistance if necessary. |
Absolutely, will do. I appreciate there's not much you can do if it's upstream of your code, and you can't observe it yourself! |
Managed to narrow it down, turns out the issue is specifically with WSL2! Now posted on the VSCode issue tracker |
Thanks @volopasse, that’s really useful to know if anyone else is having this issue! |
I don't think it's specifically for WSL2, I'm on OSx and I'm experiencing this bug as well.
|
@LongLiveCHIEF The version of Visual Studio Code Insiders you have (0913b1aa43191d8af0ccb4a133d9a8d7c1a81d69) is one of the releases from last week with the main bug, updating to the latest Visual Studio Code Insiders release should fix it for you. Please confirm that your able to use Git Graph again once you've updated to at least:
|
Seems to be fixed in e96aaa0, can see it working in the latest release
|
Has stayed fixed for me for a couple days now. |
I'm still observing this, especially after sleep/hibernate. In such case gitgraph must be closed and reopened. That's a pitty because otherwise I would pin gitgraph tab in VSCode.
|
Hi @mfmayer, For the most part this issue has seemed to be resolved by the Visual Studio Code team for the last few months. Only a handful of users have continued observe this Visual Studio Code issue, and the common cause to all of them is that they're using WSL2. Are you using WSL2? |
Describe the Bug
With the latest VSCode insider release Version: 1.46.0-insider the graph does not show. The Git Graph panel opens, only showing
Repo:
Branches:
[Checkbox] Show Remote Branches
This is both Windows 10 and Ubuntnu 20.04
Steps to Reproduce
Steps to reproduce the behaviour:
Expected Behaviour
Expect to see a Graph of commits and branches.
Environment
Ubuntu 20.04
Version: 1.46.0-insider
Commit: 1bfa086adb9271ff56be11821da686e4cfffb672
Date: 2020-06-02T06:55:30.074Z
Electron: 7.3.0
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.4.0-33-generic
Git Graph v1.23.0
Windows 10
Version: 1.46.0-insider (system setup)
Commit: 1bfa086adb9271ff56be11821da686e4cfffb672
Date: 2020-06-02T06:55:33.079Z
Electron: 7.3.0
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041
Git Graph v1.23.0
Screenshots (optional)
![Screenshot from 2020-06-02 15-22-22](https://user-images.githubusercontent.com/1935714/83525279-09606600-a4e5-11ea-87f7-20c83b4dd651.png)
The text was updated successfully, but these errors were encountered: