Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor DADA bugfixes. #211

Merged
merged 1 commit into from Apr 14, 2018
Merged

Minor DADA bugfixes. #211

merged 1 commit into from Apr 14, 2018

Conversation

cczhu
Copy link
Contributor

@cczhu cczhu commented Apr 13, 2018

Fixed passing squeeze to DADA opener; minor docs fixes. Found these while making GUPPI.

Happy to propagate these to 1.0.1 as well if approved (though they're small enough that maybe it doesn't matter).

Copy link
Owner

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but... could you add a test? And an entry in CHANGES.rst, under bugs?

Since this is an actual bug, it should indeed be backported.

@mhvk mhvk added this to the 1.0.1 milestone Apr 13, 2018
@cczhu
Copy link
Contributor Author

cczhu commented Apr 13, 2018

Sorry about the oversight - there are now tests and a mention in the changelog (hope the linking works in the docs). Once approved I'll make the same changes and release 1.0.1, then create a PR updating the changelog with the release date.

@mhvk
Copy link
Owner

mhvk commented Apr 14, 2018

@cczhu - thanks for the updates. For future reference (not important enough to worry about adding it here): when adding a test for a specific bug, it is often handy to refer to the bug issue in the comment to the test (something like "regression test for gh-211").

@mhvk mhvk merged commit 2049d24 into mhvk:master Apr 14, 2018
cczhu pushed a commit that referenced this pull request Apr 17, 2018
@cczhu cczhu deleted the dada_bugfixes branch May 22, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants