Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdsa: eth_ecdsa_sign should not sign recoverable signatures by default #41

Closed
mhw0 opened this issue Mar 27, 2024 · 2 comments
Closed

Comments

@mhw0
Copy link
Owner

mhw0 commented Mar 27, 2024

we can create two separate functions to sign both recoverable and unrecoverable signatures

@qingfengzxr
Copy link

Perhaps there is no need to deliberately distinguish, because Ethereum uses recoverable signatures as default.

@mhw0
Copy link
Owner Author

mhw0 commented May 29, 2024

Yeah, thank you. Closing the issue.

@mhw0 mhw0 closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants