Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect total coverage #264

Open
ppiastucki-vgw opened this issue Feb 15, 2024 · 1 comment
Open

Incorrect total coverage #264

ppiastucki-vgw opened this issue Feb 15, 2024 · 1 comment

Comments

@ppiastucki-vgw
Copy link

ppiastucki-vgw commented Feb 15, 2024 •
edited
Loading

Total coverage seems to be incorrect (higher than expected) compared to the coverage of individual files sometimes.
Would you please clarify what the reason might be?

Screenshot 2024-02-15 at 09 11 00
Screenshot 2024-02-15 at 09 54 17
@ppiastucki-vgw
Copy link
Author

Update:
It looks like the problem affects multi-module projects and it is caused by: https://github.com/mi-kas/kover-report/blob/main/src/reader.ts#L73.
When there are no changes in one of the modules it should disregard such a module rather than assume 100 IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppiastucki-vgw