Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release with action typings #34

Closed
krzema12 opened this issue Sep 20, 2022 · 8 comments
Closed

Please release with action typings #34

krzema12 opened this issue Sep 20, 2022 · 8 comments

Comments

@krzema12
Copy link

Some time ago this commit was merged: f795c03
It would be cool to have it released, so that it's available under v1 tag 馃槃 Could you please prepare a release?

@mi-kas
Copy link
Owner

mi-kas commented Sep 20, 2022

Sure, I will release it soon. But I have a couple of features on its way I would like to finish first before a next release (will be v2 probably)

@mi-kas
Copy link
Owner

mi-kas commented Oct 25, 2022

Closed by release v1.1

@mi-kas mi-kas closed this as completed Oct 25, 2022
@krzema12
Copy link
Author

@mi-kas thanks! Could you also update v1 tag? It still points to some older version, and our logic relies on major version tags if they're available.

@mi-kas
Copy link
Owner

mi-kas commented Oct 25, 2022

@krzema12 I'd like to go with a strict semantic versioning and therfore create always new versions for new functionalities with some backwards compability. Therefore the new action typings will be only available with v1.1.

@krzema12
Copy link
Author

krzema12 commented Oct 25, 2022

I understand and agree, but v1 isn't equal to v1.0 in GitHub's best practices 馃槃
For more context please see:

@mi-kas
Copy link
Owner

mi-kas commented Oct 25, 2022

@krzema12 Ah ok, now I got what you mean. I just updated the v1 tag with the most recent changes. Thanks for the suggestion 馃憤

@krzema12
Copy link
Author

Cool, thanks!

@krzema12
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants