Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function signature does not match other functions #32

Open
kingledion opened this issue Jan 15, 2023 · 0 comments
Open

Remove function signature does not match other functions #32

kingledion opened this issue Jan 15, 2023 · 0 comments

Comments

@kingledion
Copy link
Contributor

kingledion commented Jan 15, 2023

The remove function signature:

pub async fn remove<T: TypedCouchDocument>(&self, doc: &T) -> bool

does not return a Result like the function signatures for other 'CRUD' operations create, save and upsert.

Remove should be changed (or possibly deprecated and replaced with a new 'delete') to return a CouchResult so that any errors as well as the http status for the db call call can be returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant