Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification protocol should define message charset #41

Closed
GoogleCodeExporter opened this issue Jan 29, 2016 · 5 comments
Closed

Notification protocol should define message charset #41

GoogleCodeExporter opened this issue Jan 29, 2016 · 5 comments

Comments

@GoogleCodeExporter
Copy link

Looking at the code, I see that android-notifier calls getBytes() on messages 
without specifying a charset thus making the message encoding platform 
dependent. This manifests itself in the desktop app with accentuated characters 
not showing correctly.

The notification protocol should define a charset to be used in all messages 
such as ISO-8859-1.

Original issue reported on code.google.com by lehph...@gmail.com on 30 Aug 2010 at 2:16

@GoogleCodeExporter
Copy link
Author

Very reasonable.
I'll change it to be UTF8 unless you have some reason to believe 8859 would be 
better.

Original comment by rdamazio@gmail.com on 30 Aug 2010 at 4:36

  • Changed state: Accepted
  • Added labels: Component-Communication, Component-Docs, Maintainability, OpSys-Android, OpSys-Linux, OpSys-OSX, Priority-High
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

UTF-8 is ok, thanks.

Original comment by lehph...@gmail.com on 30 Aug 2010 at 5:30

@GoogleCodeExporter
Copy link
Author

Original comment by rdamazio@gmail.com on 12 Sep 2010 at 6:29

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Done in r230.

Original comment by rdamazio@gmail.com on 12 Sep 2010 at 6:32

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by rdamazio@gmail.com on 19 Sep 2010 at 6:43

  • Changed state: Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant