Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a rule bounces back to General tab #26

Closed
jt-github opened this issue Feb 2, 2022 · 5 comments
Closed

Saving a rule bounces back to General tab #26

jt-github opened this issue Feb 2, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@jt-github
Copy link

Saving any rule in the MFE Settings app causes the focus to return to the General tab. It should instead stay focused on the currently visible tab (and just disable the Save button).

@xmine64
Copy link
Member

xmine64 commented Feb 2, 2022

I know, but I can't do that. It returns to General tab because it reloads config file.

@jt-github
Copy link
Author

Ah, makes sense, but I suspect it wouldn't be too hard to store the current tab in a variable (each time you change tabs) and then, upon loading the config, attempt to return to that stored tab if it still exists.

@xmine64
Copy link
Member

xmine64 commented Feb 3, 2022

That would be nice, You're right this is possible. I didn't try to save it because it may doesn't exist, but I can check if it exists then return to that tab.

@xmine64 xmine64 closed this as completed in 7a66826 Feb 3, 2022
@jt-github
Copy link
Author

Awesome. Works well!

One behavior I'm observing in the current version that could be seen as either distracting or a good way to remind users that they need to Save to apply changes:
Switch from the General tab to any other tab and the Save button will very briefly appear as enabled and then switch to the disabled state.

@xmine64
Copy link
Member

xmine64 commented Feb 3, 2022

Well I don't handle enabling and disabling save button, I let xaml binding do that for me.

@dongle-the-gadget dongle-the-gadget added the enhancement New feature or request label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants