Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning pip requirements and added instructions for windows #25

Merged
merged 3 commits into from Oct 12, 2021

Conversation

Tri125
Copy link
Contributor

@Tri125 Tri125 commented Oct 10, 2021

This PR contain 3 set of changes all aimed to make it easier to clone and start using the project.

  1. I pinned specific versions in the requirements.txt file. Without specifying any version, pip was backtracking for over 10h trying to figure out which version of the dependencies to use. The versions could definitively be less strict but at the very least now it only takes a few second to setup. I would recommend testing on Linux/Docker before merging.
  2. Since the README already mentioned the existence of the assets folder, I thought it would improve the experience for it to be part of the repository.
  3. I documented the need to setup openh264 and FFmpeg for windows to be able to run the project.

@micah5 micah5 merged commit 9749142 into micah5:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants