Huge packaging refactor #1208
Merged
Huge packaging refactor #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython packages and get them from pyproject.toml instead
…s from snap because they are defined in poetry; fix onionshare and onionshare-gui snap apps definition; switch back to download Qt5 from the internet
…; update Tor; update build instructions
…macOS sandbox because this is required for PyInstaller and Catalina
…rt refactoring it to work with briefcase
… delete some unnecessary files from desktop/install
… to src so flatpak can see it, reduce python dependencies, and update release docs
SaptakS
reviewed
Nov 9, 2020
| "settings_error_missing_password": "Connected to Tor controller, but it requires a password to authenticate.", | ||
| "settings_error_unreadable_cookie_file": "Connected to the Tor controller, but password may be wrong, or your user is not permitted to read the cookie file.", | ||
| "settings_error_bundled_tor_not_supported": "Using the Tor version that comes with OnionShare does not work in developer mode on Windows or macOS.", | ||
| "settings_error_bundled_tor_timeout": "Taking too long to connect to Tor. Maybe you aren't connected to the Internet, or have an inaccurate system clock?", |
There was a problem hiding this comment.
This should also fix #1184 and the comment I mentioned.
…uild scripts to properly delete last build
…nts crashes after running the tests; and fix msi_filename in Windows build script
…cond when cleaning up MainWindow so loose threads can finish
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't change much in the actual logic of OnionShare. But it does change all of this:
onionshare(former CLI) toonionshare-cliandonionshare-gui(former GUI) to justonionsharecliand the GUI project is indesktopcli/README.mdhas build instructions for the CLI appdesktop/README.mdhas build instructions for the desktop appRELEASE.mdhas instructions for making a release -- and these instructions are much more thorough, and describe all the new platforms OnionShare will supportflatpakdirsnapdirThings left to do:
cli/onionshare_cli/onion.py-- the CLI version is not localized at all, so all of the strings are in the desktop version. Right now, Tor-related error messages are all only in English, but they should continue to get localizedResolves #1200, #1111, #910, #1107, #1009 (mostly), #834