Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrongly detects language #220

Closed
h01ger opened this issue Feb 17, 2016 · 1 comment
Closed

wrongly detects language #220

h01ger opened this issue Feb 17, 2016 · 1 comment
Milestone
0.2.3

Comments

@h01ger
Copy link
Contributor

h01ger commented Feb 17, 2016

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753173 was has lots of more background about this issue. Basically, if you've set any LC_ variable to an existing locale, torbrowser will start in this languge, which is wrong, as many LC_ variables have nothing to do with UI language.

The fix is rather simple (and confirmed by me):

http://sources.debian.net/src/torbrowser-launcher/0.2.2-3/torbrowser_launcher/common.py/#L74

which currently reads:

default_locale = locale.getdefaultlocale()[0]

should instead be:

default_locale = locale.getlocale(locale.LC_MESSAGES)[0]
@micahflee micahflee modified the milestone: 0.2.3 Mar 1, 2016
@rogers0
Copy link
Contributor

rogers0 commented Nov 12, 2018

b828bdf
reverted previous fix, so it's broken again.
Could you kindly consider to revert? Thanks!

@rogers0 rogers0 mentioned this issue Nov 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.3
Development

No branches or pull requests
3 participants
@micahflee @rogers0 @h01ger