Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow torbrowser to access u2f devices #434

Merged
merged 1 commit into from Nov 7, 2019

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Oct 23, 2019

Start of discussion, see https://redmine.tails.boum.org/code/issues/17153

@intrigeri: I have tried to refine the rules a bit. And I realized that there might be differences between U2F devices, the (older) Yubikey NEO needs an additional permission. There might be additional rules needed for other U2F devices.

Copy link
Collaborator

@intrigeri intrigeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the rule I've specifically commented about! Thank you :)

apparmor/torbrowser.Browser.firefox Outdated Show resolved Hide resolved
@intrigeri
Copy link
Collaborator

intrigeri commented Nov 7, 2019 via email

@b1rger
Copy link
Contributor Author

b1rger commented Nov 7, 2019

Hi,

We could only allow c24{7,9}:*?

Sounds good to me!

I've updated the MR!

@intrigeri intrigeri merged commit e1314eb into torproject:develop Nov 7, 2019
@GtyTz
Copy link

GtyTz commented Jun 2, 2021

I was wondering if anyone could just point me in the right direction in order to add this patch to tails.

I'm a complete novice I have managed to instal tails and set up persistent etc. so i know the basics.
usually if i have problems, i'll go to git hub or reddit and i find the solution. tytpically thats just following the directions and go to terminal copy/paste and majority of the time it works.

however i tried just copy and pasting this code into terminal but i get a permission denied

did some research online and tails has a tutorial on how to update app armor https://tails.boum.org/contribute/release_process/tor-browser_AppArmor_patch/

however that too also gave me a permision denied. i tried twice, first said the software key was not recognised and asked if i wanted to proceed and since i trust tails website and where the info came from, i selected yes, after that the terminal just froze.

so i closed and tried again and got the other persion denied below

$ git clone git@gitlab.tails.boum.org:tails/torbrowser-launcher &&

cd torbrowser-launcher &&
git remote add salsa https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher.git &&
git remote add upstream-repo https://github.com/micahflee/torbrowser-launcher
Cloning into 'torbrowser-launcher'...
git@gitlab.tails.boum.org: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

again if anyone could just point me in the right direction to find a solution
I know its something so stupid , but without the proper basics i have been spinning my wheels for a few days and its driving me bonkers hahaha

@intrigeri
Copy link
Collaborator

intrigeri commented Jun 2, 2021 via email

@GtyTz
Copy link

GtyTz commented Jun 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants