Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All horizontal slabs went vertical #69

Closed
AstoriaWinters opened this issue Dec 31, 2021 · 9 comments
Closed

All horizontal slabs went vertical #69

AstoriaWinters opened this issue Dec 31, 2021 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@AstoriaWinters
Copy link

So, I installed this mod in an already established world. Thinking nothing of it. Unfortunately, it has made every single slab that was already placed, vertical. My Staff and I have just spent the better part of 3hrs fixing things, but could this be fixed in future? I feel bad for anyone else who has to go thru that.

@Micalobia
Copy link
Owner

That shouldn't be possible, it's supposed to default to vanilla slab positions. Is that in the 1.18 version, and what other mods do you have installed?
It might fix itself if the mod is uninstalled, but vertical slabs would also go horizontal in that case for obvious reasons.

@Micalobia Micalobia self-assigned this Jan 1, 2022
@Micalobia Micalobia added bug Something isn't working question Further information is requested labels Jan 1, 2022
@AstoriaWinters
Copy link
Author

It is the 1.18 version yes, and my server has about 70 mods required by the player and another 40 or so that are server only (its an origins server). I don't think there's anything that would affect the slabs like this? But I am going to go into SP today and test it out as well. Try to see what mod the issue lies in. On that note tho- Additional Bars mod, the horizontal bars crash when seen vertical which was interesting lol

Also ran into a problem where apparently the slabs will reset back into vertical after being fixed to be horizontal. I attached 2 pics one of my players sent me of the issue as well.

2022-01-01_09 46 29
2022-01-01_09 46 49
l

@AstoriaWinters
Copy link
Author

AstoriaWinters commented Jan 1, 2022

So, just tested it. all I have is- Full Slabb 3.3.1, Fabric API 0.45.0 and Cloth Config 6.1.48. I have the latest version of Cloth Cofig and Fabric API, so I am unsure.
image

@AstoriaWinters
Copy link
Author

Here is the log file that goes with that screenshot btw. I forgot to add ti in there.

latest.log

@Joulanh
Copy link

Joulanh commented Jan 1, 2022

I just wanted to report this so i did some testing myself. The only thing i'd add is that after removing the mod, as far as i know slabs, stairs, stripped logs and trapdoors are all set into the same rotation or blockstate.

And there is another critical bug. If you remove the mod, leaves start to decay in the chunks that were loaded with the mod installed. I had this issue after i removed the mod on my server because it set all slabs to vertical, and since i have a mod installed that lets leaves decay faster suddendly every single leave around me was gone. If you wanna test this without extra mods, raising the gamerule randomtickspeed is a good way to go.

Here are some screenshots in order: Full slabs never installed -> with fullslabs installed afterwarts -> after removing fullslabs again

Before installing fullslabs:

2022-01-01_14 35 30

2022-01-01_14 44 24

With fullslabs installed:
(I added a leavebush because the decay also includes leaves with the persistent tag)
-> only the slabs turned vertical

2022-01-01_14 42 06

2022-01-01_14 44 24

After removing fullslabs:
-> stripped logs, stairs, slabs, and trapdoors rotation was changed compared to before installing fullslabs
-> some leaves decayed on trees, leaves on the ground are gone

2022-01-01_14 43 57

2022-01-01_14 46 11

After repeating installing and removing the mod for a second time:
-> all leaves are gone now

2022-01-01_14 46 16

@Micalobia
Copy link
Owner

This is super weird, might be a bug with the Statement API, will 100% have to look more into this, thank you for reporting, y'all got very in-depth which is extremely helpful

@Micalobia Micalobia removed the question Further information is requested label Jan 1, 2022
@dandin87
Copy link

dandin87 commented Jan 3, 2022

This is also happening on All of Fabric 5. already placed slabs turn vertical.

@Micalobia
Copy link
Owner

This is waiting on Virtuoel/Statement#13, which is then waiting on Virtuoel/Statement/milestone/1.

Don't pester Virtuoel about it, hopefully the fix is soon but patience is important.

@Micalobia Micalobia pinned this issue Jan 7, 2022
@Micalobia
Copy link
Owner

This is resolved now in Full Slabs 3.3.3, thank y'all for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants