Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Password Form #6

Closed
lewiswharf opened this issue Dec 11, 2011 · 4 comments
Closed

Reset Password Form #6

lewiswharf opened this issue Dec 11, 2011 · 4 comments

Comments

@lewiswharf
Copy link

<xsl:with-param name="redirect" select="substring-before($current-url, '?')"/>

That destroys success XML and is tricky to catch. I suggest removing it.

@michael-e
Copy link
Owner

Of course, you are right. It is hard to understand what will happen if you actually use a redirect.

Would you prefer commenting it out (so you can still see that it would be possible — it's just an example file…) or really remove that line?

@lewiswharf
Copy link
Author

For me, the actual redirect is the problem. Since I want to use your templates to speed things up I didn't look at that part very closely and missed that there was a redirect being passed. Furthermore, substring-before($current-url, '?') was hard to catch because to me, the URL had not changed and that's why I thought the problem originally stemmed from the Member's event.

If you want to keep that line in there as an example, I would suggest changing the redirect to the login page so that it is more obvious.

@michael-e
Copy link
Owner

Fixed here: 7e8f9e3 and 1d6fd4b

@michael-e
Copy link
Owner

Thanks, Lewis, for finding this shortfall. Actually I had removed the redirect in my live templates, but kept it in the example code. Now I removed it and added a note about redirects in the README. Updated to 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants