-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved common code to shared project #10
Conversation
Looks good - the next steps (for Issue #6) to bring in a WebAssembly head are listed here on the Uno site (it's a bit of a clunky manual process at the moment): https://platform.uno/docs/articles/migrating-apps.html |
I would think the |
That depends on how we plan on pulling in the pages for the all-samples app. If we place each sample page in its respective app project, we're no longer able to reference it from the WASM projects nor the all-samples app. So since we need both 1) a slimmed-down, single sample app that compiles quickly (Uno-Quickstart style) and 2) the ability to reference sample pages from both single-sample apps and all-sample apps. The solutions are to either:
I prefer option 1 for various reasons, but 'm not sure option 2 would be possible for single-sample apps since it means all sample pages would be in the shared project, and thus all references need to exist at build time 🤔 |
@michael-hawker I'll address these things in another PR when I set up the sample page correlation. |
First time setup of a shared project to be used between the various sample app heads (both UWP and other platforms). Part of #1 and needed for #6.
.\App.UWP.props
to.\Common\Labs.Uwp.props
-- theLabs.Wasm.props
for Uno will come later.The all-solution now looks like:
![image](https://user-images.githubusercontent.com/9384894/145101568-e3185bdf-75ba-4ad3-8a96-0037546cdac0.png)
The CanvasLayout solution now looks like:
![image](https://user-images.githubusercontent.com/9384894/145101677-9fe28d40-3fa7-466e-8c39-b1a7374245c4.png)