-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define summaries depending on current value #24
Comments
Here is another example of the design spec: Source: https://material.io/guidelines/patterns/settings.html#settings-labels-secondary-text |
I am glad that you like the library. It is correct that the library does not provide the functionality you are describing. This is because the library does only provide an activity where preferences can be placed in (the standard preferences as provided by the Android SDK or those provided by 3rd party libraries), but does not add additional functionality to them besides adjusting their appearance (a little bit). Therefore the feature you are requesting is out of scope of this library. I usually use this library together with another library of mine. It is called AndroidMaterialPreferences. Said library allows to display the current value of a preference as its summary by specifying the XML attribute |
By the way: Even with the Android SDK's standard https://developer.android.com/reference/android/preference/CheckBoxPreference.html |
Thanks for the explanation. I wanted to check out your other library anyway so thats good. I will do that create a new issue there if it makes sense to do so. I did know about the checkbox preferences' "on" and "off" attributes, they just are not sufficient for other preference types (as you know too). |
Hi there,
I really like your work so far. There is something about the material design specs that I don't know how to implement with this library:
I would love to see this implemented in the library if it hasn't already as imo the current implementation does not math the specification.
To implement this myself I currently need to do a lot of boilerplate code in the activity that changes the description based on preference value changes. It would be great if there was a way to specify what summaries should be shown for the different Preference types f.ex. using a string with placeholders or something similar that is filled by this library without having to do any boilerplate on the activity side.
The text was updated successfully, but these errors were encountered: