Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue for running gulp #8

Closed
0x333333 opened this issue Dec 15, 2015 · 1 comment
Closed

Issue for running gulp #8

0x333333 opened this issue Dec 15, 2015 · 1 comment

Comments

@0x333333
Copy link
Contributor

Hi,

I came across this issue when I did gulp after npm i.

/Users/zhipeng/Development/angular-es6/node_modules/gulp-less/index.js:68
    }).done(undefined, cb);
       ^

TypeError: less.render(...).then(...).catch(...).done is not a function
    at DestroyableTransform._transform (/Users/zhipeng/Development/angular-es6/node_modules/gulp-less/index.js:68:8)
    at DestroyableTransform.Transform._read (/Users/zhipeng/Development/angular-es6/node_modules/gulp-less/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at DestroyableTransform.Transform._write (/Users/zhipeng/Development/angular-es6/node_modules/gulp-less/node_modules/readable-stream/lib/_stream_transform.js:172:12)
    at doWrite (/Users/zhipeng/Development/angular-es6/node_modules/gulp-less/node_modules/readable-stream/lib/_stream_writable.js:237:10)
    at writeOrBuffer (/Users/zhipeng/Development/angular-es6/node_modules/gulp-less/node_modules/readable-stream/lib/_stream_writable.js:227:5)
    at DestroyableTransform.Writable.write (/Users/zhipeng/Development/angular-es6/node_modules/gulp-less/node_modules/readable-stream/lib/_stream_writable.js:194:11)
    at write (/Users/zhipeng/Development/angular-es6/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:623:24)
    at flow (/Users/zhipeng/Development/angular-es6/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:632:7)
    at DestroyableTransform.pipeOnReadable (/Users/zhipeng/Development/angular-es6/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:664:5)
    at emitNone (events.js:67:13)

I searched a little bit, then I found this gulp-community/gulp-less#140, in the previous version of gulp-less there was not such a function done(). That issue can be fixed simply by using the latest version of gulp-less. I try that and it works.

So I will request a PR to bump the version of gulp-less, can you have a look at this?

Thanks in advance!

@michaelbromley
Copy link
Owner

Thanks - merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants