Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mocking of unit tests accessing production services #54

Closed
tomkralidis opened this issue Nov 15, 2021 · 2 comments
Closed

mocking of unit tests accessing production services #54

tomkralidis opened this issue Nov 15, 2021 · 2 comments

Comments

@tomkralidis
Copy link

(disclaimer: I'm the architect of the ECCC/MSC GeoMet API platform, which provides some of the data/services used in this project).

Great work here! If possible, it would be valuable to implement test data/mocking as part of the tests so as not to test against production/operational instances.
@michaeldavie
Copy link
Owner

Thanks for the suggestion. Is there a problem with testing against the live system? The tests are not volumetric and are typically only ran when new commits are made.

@tomkralidis
Copy link
Author

Mostly a suggestion in the case that the code is used/tested beyond this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomkralidis @michaeldavie