Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function calls with objects in template strings mismatching closing } #44

Open
rattrayalex-stripe opened this issue Mar 5, 2019 · 5 comments

Comments

@rattrayalex-stripe
Copy link

current behavior:

screen shot 2019-03-04 at 9 47 21 pm

github's behavior here is a bit better:

`hello ${world({
  one: 1,
  two: 2,
})} how are you`

specifically, the ${} characters should be a different color than the text, and the code inside should receive normal syntax highlighting.

I believe that the "Sublime Babel" vscode extension also has pretty good behavior here.

@michaelgmcd
Copy link
Owner

Hmm. This doesn't seem to be an issue on my machine. What theme are you using?

Screen Shot 2019-05-13 at 4 56 20 PM

@rattrayalex-stripe
Copy link
Author

rattrayalex-stripe commented May 14, 2019

@michaelgmcd Looks like I'm on Dark+ (default dark) – is that supported?
(Note that it has the same issue on Solarized dark)

@michaelgmcd
Copy link
Owner

Sorry for the delay. Can you try the "Palenight Italic" theme I'm using in the screenshot above?

@rattrayalex-stripe
Copy link
Author

rattrayalex-stripe commented Jun 5, 2019

I do get the same result as you (it seems less broken), though it too is broken with the "Bracket Pair Colorizer" extension that I have:

Screen Shot 2019-06-05 at 2 58 04 PM

Note the closing }) which should be pink and then yellow

@rattrayalex-stripe
Copy link
Author

@michaelgmcd any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants