Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional support for canonical URL meta tag. #29

Merged
merged 1 commit into from Sep 2, 2015
Merged

Optional support for canonical URL meta tag. #29

merged 1 commit into from Sep 2, 2015

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Aug 29, 2015

This is very roughed in, but it adds support for returning the URL as provided by the canonical link element.

There isn't anything to determine precedence with og:url.

Has passing tests, and is disabled by default.

Needed this for a project, not sure if it would be useful upstream.

@michaelhelmick
Copy link
Owner

Thanks! One quick thing, can you provide a link on the internet I can test this against? Also, do you think we need to make it a setting?

Also, feel free to add yourself to AUTHORS.

I can see this being useful! :D

@jmhobbs
Copy link
Contributor Author

jmhobbs commented Sep 1, 2015

Here's a test URL with a canonical tag on it;

https://dl.dropboxusercontent.com/u/28665584/lassie-canonical-urls/index.html

I made it a setting because I didn't want to change existing behavior, I'm fine with it being default though.

@michaelhelmick
Copy link
Owner

I meant to delete the later question. Haha. I realized the other stuff was a setting.

I'll test this tomorrow morning and get a release out

michaelhelmick added a commit that referenced this pull request Sep 2, 2015
Optional support for canonical URL meta tag.
@michaelhelmick michaelhelmick merged commit 0df6f76 into michaelhelmick:master Sep 2, 2015
@michaelhelmick
Copy link
Owner

0.6.0 is available on pypi!

@jmhobbs
Copy link
Contributor Author

jmhobbs commented Sep 2, 2015

Thanks @michaelhelmick!🎈🎊🎂

@jmhobbs jmhobbs deleted the feature/meta-canonical-url branch September 3, 2015 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants