Don't reverse names in get_qualification #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakobandersen Could you confirm this is the correct thing to do? To me it looks good, but perhaps this is pointing at another bug elsewhere regarding some assumptions in the data received? |
|
Good find! However the suggested fix would break other cases. See the code comments. |
E.g. a function a::b::c::foo() is otherwise incorrectly displayed at c::b::a::foo()
martinus
force-pushed
the
fix-reversed-nested-namespaces
branch
from
898b405
to
0618acc
Compare
|
Thanks, I've updated the PR as you suggested |
|
Nice. I think the PR is ok for merging, and the fix is semantically correct, but I actually can't immediately construct an example right now that distinguishes it from the original PR. |
vermeeren
approved these changes
Jun 7, 2020
|
Just released v4.19.0 with the fix, all should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. a function
a::b::c::foo()is otherwise incorrectly displayed atc::b::a::foo().Fixes #539.