Splice out parameter direction in field lists #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
approved these changes
Apr 14, 2021
vermeeren
added
bug
vermeeren
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
@jakobandersen Thanks a lot for the fix and apologies for the long wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673 (and #674).
This is digging into the parameter XML and extracting the parameter direction. If present it is then injected in the beginning of the field body instead. Example:
There are quite a some of (relatively reasonable) assumptions of the XML structure to do this. Perhaps some people with larger projects could double check that it works before merging.