.github/workflows/unit_tests.yml: Update it #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
update-ci-and-sphinx-versions
branch
from
9d6e706
to
0da8792
Compare
|
Thanks for the PR. It seems that the latest Sphinx doesn't support Python 3.7 despite 3.7 still being officially supported for the next 4 months. I assume that's fine. Sphinx 4.5 was only released in March last year though. Might it still be reasonable to support it for a bit or are there signs that the ecosystem is leaving it behind? @jakobandersen - do you have any thoughts on this? |
Only keep the last two major versions for sphinx and drop 4.x. In addition sphinx 6.0 dropped support for python 3.7, so we do the same. Both changes allow us to remove all matrix excludes.
|
My reasoning was that supporting the current and previous major version of sphinx should be enough. I also pushed a fix as I forgot to update requirements/production.txt. |
t-b
force-pushed
the
update-ci-and-sphinx-versions
branch
from
0da8792
to
abe8c39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only keep the last two major versions for sphinx and drop 4.x. In addition sphinx 6.0 dropped support for python 3.7, so we do the same.
Both changes allow us to remove all matrix excludes.
Close #884