Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in Jenkins with recently released 1.23.2 #106

Closed
IdanAdar opened this issue Jan 12, 2020 · 13 comments
Closed

Failure in Jenkins with recently released 1.23.2 #106

IdanAdar opened this issue Jan 12, 2020 · 13 comments

Comments

@IdanAdar
Copy link

IdanAdar commented Jan 12, 2020

Starting 1.23.2 after tests have passed/failed in Jenkins the following error is printed:

 139 passing (16m)


=============================== Coverage summary ===============================
Statements   : 89.09% ( 1053/1182 )
Branches     : 79.29% ( 356/449 )
Functions    : 89.82% ( 150/167 )
Lines        : 89.05% ( 1041/1169 )
================================================================================
[Pipeline] junit
Recording test results
No test report files were found. Configuration error?

If going back to 1.23.1, everything works as expected, so looks like one of these changes created a regression: v1.23.1...master

@clayreimann You seem to be the one who pushed code most recently.
@michaelleeallen FYI.

@clayreimann
Copy link
Collaborator

@IdanAdar Can you provide more context?

  • What version of mocha?
  • What version of node?
  • Are you using other software (nyc, webpack, etc.)?
  • Can you provide a reproducible example project?
  • Are there other errors in the output?

@jensteichert
Copy link

Having a similar issue on CircleCI with mocha 6.2.0, circleci/node:10 and nyc.

@IdanAdar
Copy link
Author

Node 12.13, mocha 6.2.2.
This started the second 1.23.2 was released and is resolved if going back to 1.23.1.

@clayreimann
Copy link
Collaborator

And the problem appears to be that no result file is produced?

Sent with GitHawk

@holm
Copy link

holm commented Jan 12, 2020

We see the same on Circle CI. It seems no result file is produced.

@justinau
Copy link

Same issue here, Node 12, Mocha 7
In my case the "No test report files were found" is misleading. It's creating a result file but it's using the default filename test-results.xml, we're using --reporter-options with a custom mochaFile but it's being ignored.

fresh npm install on the repo installs mocha 5 and all tests pass, if you bump that to mocha6+ the tests fail.

@theduykh
Copy link

Facing the same issue when working with mocha-multi-reporters. 1.23.1 works well.
Please also test with mocha-multi-reporters.

@flannanl
Copy link

I have similar issue. With v1.23.1, using the options, --reporter-options, with a custom mochaFile does not work. It is always creating the results xml in the root directory with default filename, test-results.xml.

It seems it is related to the recent change in this line: https://github.com/michaelleeallen/mocha-junit-reporter/blob/master/index.js#L43

@walkerdb
Copy link

walkerdb commented Jan 14, 2020

We are seeing the same issue -- this reporter stopped respecting our reporter-options on 1.23.2 . --reporter-option mochaFile=./build/test-results-unit.xml no longer works.

Downgrading to 1.23.1 resolved the problem for us.

We're on mocha 7.0.0, node 12.4.0

@mirao
Copy link

mirao commented Jan 14, 2020

Same issue with CodeceptJS 2.4.1, NodeJS v10.18.1, mocha@6.2.2, mocha-junit-reporter@1.23.2.
Configuration option mochaFile: "./output/result.xml" in CodeceptJS stopped working.
I had to downgrade to 1.23.1: npm i mocha-junit-reporter@1.23.1

@clayreimann
Copy link
Collaborator

Sorry for the heartache. I’ll see if I can–at least–get a patch release out today that reverts the changes that went in over the weekend while I look into the root cause

Sent with GitHawk

@IdanAdar
Copy link
Author

@clayreimann were you able to work out patch?

@clayreimann
Copy link
Collaborator

This should be resolved with 1.23.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants