Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Branch reviews #17

Closed
theduke opened this issue Aug 17, 2018 · 4 comments
Closed

feat: Branch reviews #17

theduke opened this issue Aug 17, 2018 · 4 comments

Comments

@theduke
Copy link

theduke commented Aug 17, 2018

This is a really cool project.

The next step for me would be to support branch reviews with discussions to replace merge requests.
Do you have any plans for this?

The rough features needed would be:

  • multi-user discussions on changesets within files
  • marking a change as "needs improvements"
  • Resolving discussions and improvement requests
  • Marking a commit as approved

ps: I'm happy to help out with this if you see this within the project scope.

@theduke
Copy link
Author

theduke commented Aug 17, 2018

I just discovered https://github.com/google/git-appraise, which is pretty what this would be.

Depending on the storage model etc it could either make sense to re-implement this or possibly to have an integration with git-appraise.
Especially on the UI part.

So one approach could be to add a git-appraise view in the webui.

@yrashk
Copy link

yrashk commented Aug 18, 2018

In SIT, we're just including git format-patch files into issues to do merge requests and discussions can go on there. We don't have a way to comment on specific lines, but this is just a matter of designating some kind of referencing convention for comment records.

Maybe this can be of some use/inspiration here?

@hab25
Copy link

hab25 commented Aug 21, 2022

In SIT, we're just including git format-patch files into issues to do merge requests

@yrashk, did you have CI/CD and automate the enforcement of constraints such as required minimum number of approvals? If so, how?

@MichaelMure
Copy link
Owner

Closing as duplicate of #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants