Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug report #9

Open
loadingyy opened this issue May 2, 2024 · 0 comments
Open

bug report #9

loadingyy opened this issue May 2, 2024 · 0 comments

Comments

@loadingyy
Copy link

I found a bug in your code.
When i register a hook to lora_A tensor, I found that its backward times will increase.
Which means that, in batch n, the output of lora block will backward its grad to all the lora pair before, the hook said that, the output of lora backward to "from lora in batch n to lora in batch 0". And then , only one backward to the input of lora block. But surprisely, the memory doesn't increase. I wonder why it happened. I think it might have something is cumulate cross the batch, and its grad is crossing the lora pair.
Sorry for my poor English, and if you didn't get my mean, please tell me.Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant