Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find namespace 'FirebaseFirestore'. #22

Closed
MvRemmerden opened this issue Aug 7, 2018 · 11 comments
Closed

Cannot find namespace 'FirebaseFirestore'. #22

MvRemmerden opened this issue Aug 7, 2018 · 11 comments

Comments

@MvRemmerden
Copy link

MvRemmerden commented Aug 7, 2018

After updating to 2.1.0., the following error appears: Cannot find namespace 'FirebaseFirestore'.

I was able to fix it by changing FirebaseFirestore.CollectionReference to typesWeb.CollectionReference in the following lines:

export namespace cloud { export interface CollectionReference extends FirebaseFirestore.CollectionReference { } }

I have created PR to fix this issue. #23

@MichaelSolati
Copy link
Owner

Oy vey! @MvRemmerden that may not work for the cloud functions. Shoot, I'll get on this right away (thank you for making me aware)

@MvRemmerden
Copy link
Author

Ah, makes sense, I was just testing out the firestore queries, not the cloud functions. And no worries, always happy to help :)

@MichaelSolati
Copy link
Owner

Can you post a screenshot of the error, as well as what version of Typescript you're using?

@MvRemmerden
Copy link
Author

screen shot 2018-08-07 at 09 24 03

TypeScript 2.6.2

@MichaelSolati
Copy link
Owner

Fascinating, I'm not getting this. Mind you I'm on Typescript 3.0.1... Hrmm, ok, I can try and work from this!

@MvRemmerden
Copy link
Author

Just updated to Typescript 3.0.1, still same error. Might be due to my project running on Ionic and with AngularFire2.

@MichaelSolati
Copy link
Owner

Yea, that didn't fix it, I'll have to try more tomorrow in the morning. Ughhh, sorry for the inconvenience!

@MvRemmerden
Copy link
Author

No worries, it's not an inconvenience at all, as I don't need the cloud functions and can just continue with my forked version.

@MichaelSolati
Copy link
Owner

Try npm i MichaelSolati/geofirestore#dev, I've tried it with a few different projects and a few different versions of Typescript. If I get a yes that works I'll be deploying it to NPM today!

@MichaelSolati MichaelSolati reopened this Aug 7, 2018
@MichaelSolati
Copy link
Owner

@MvRemmerden I'm gonna take it as we're fine and deploy 2.1.1

@MvRemmerden
Copy link
Author

Sorry for the late reaction, yes it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants