Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wsrep_sst_method #7

Merged
merged 2 commits into from May 3, 2014
Merged

Conversation

rickerc
Copy link
Contributor

@rickerc rickerc commented May 2, 2014

Allow selection of wsrep_sst_method to support platforms such as Ubuntu
trusty on which the default rsync SST method will not work with Percona
XtraDB.

@michaeltchapman
Copy link
Collaborator

I have the linter set to be fairly strict at the moment. It's failing on http://puppet-lint.com/checks/variables_not_enclosed/

Allow selection of wsrep_sst_method to support platforms such as Ubuntu
trusty on which the default rsync SST method will not work with Percona
XtraDB.
@rickerc
Copy link
Contributor Author

rickerc commented May 3, 2014

hmm, the lines it fails on are:

$wsrep_sst_auth = "root:${galera::root_password}"

warning("wsrep_sst_method of ${galera::wsrep_sst_method} not recognized and may need authentication configured")

Those both look fine and pass local lint:

$ puppet-lint params.pp
WARNING: line has more than 80 characters on line 63
WARNING: line has more than 80 characters on line 68
WARNING: line has more than 80 characters on line 76
$

(and if I drop the brackets from 64 it then fails with
WARNING: variable not enclosed in {} on line 64
so my local puppet-lint is definitely checking that)

I wonder if Travis is somehow caching because of the amend commits? The logs look like its doing a new checkout but...

Clean up a couple of overly long lines.
@rickerc
Copy link
Contributor Author

rickerc commented May 3, 2014

Ok, that was it -- can't do an amend commit to fix a failing lint test apparently. Thanks!

(though it's more github being silly rather than Travis, apparently)

@michaeltchapman
Copy link
Collaborator

If you amend and push -f it doesn't re-launch the tests?

michaeltchapman added a commit that referenced this pull request May 3, 2014
@michaeltchapman michaeltchapman merged commit d342cf6 into markt-de:master May 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants