Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the naming of the filters, head_{...}, content_{...}, and foot_{...} #34

Closed
michaeluno opened this issue Dec 4, 2013 · 4 comments
Labels
Milestone

Comments

@michaeluno
Copy link
Owner

head_ + page slug – receives the output of the top part of the page.
head_ + page slug + _ + tab slug – receives the output of the top part of the page.
head_ + extended class name – receives the output of the top part of the page, applied to all pages created by the instantiated class object.
content_ + page slug – receives the output of the middle part of the page including form input fields.
content_ + page slug + _ + tab slug – receives the output of the middle part of the page including form input fields.
content_ + extended class name – receives the output of the middle part of the page, applied to all pages created by the instantiated class object.
foot_ + page slug – receives the output of the bottom part of the page.
foot_ + page slug + _ + tab slug – receives the output of the bottom part of the page.
foot_ + extended class name – receives the output of the bottom part of the page, applied to all pages created by the instantiated class object.

The words, head and foot might not be the best naming choices for these filters because they often remind of the head and foot HTML tags, not the positions.

So instead of head, content, and foot, it might be better to replace them with top, middle, and bottom.

[Edit]
Now I started to think top_{...}, middle_{...}, and bottom_{...} are not enough either because they won't remind of string contents. Maybe top_content_{...}, middle_content_{...}, and bottom_content_{...} could be better. I don't know.

@michaeluno
Copy link
Owner Author

At this time, they will be:

  • content_top_{...}
  • content_{...}
  • content_bottom_{...}

If you have a better idea, it should be addressed before v3 gets released.

@michaeluno
Copy link
Owner Author

Done.

@michaeluno
Copy link
Owner Author

Now I think

  • content_head_{...}
  • content_{...}
  • content_foot_{...}

is better.

@michaeluno michaeluno reopened this Feb 6, 2014
@michaeluno
Copy link
Owner Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant