-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Add year to ZIP files #31
Comments
Thanks for the suggestion. |
Thanks! Though I found a small issue when the movie title contains the year. You'll get double years, in both the ZIP and the VTT files, but it's not really that important. It's more important having the year in the ZIP file name. iTunes kinda sucks regarding the year data. The year on the movie page seems to sometimes be the region's release date (or digital release maybe?). So you get silly things like "Fantasia (1940)" having a release date of 1990. So in a way it's good to have double years, but it's kinda annoying with the same year twice. Cinderella.1950.1950.iT.WEB Dumbo.1941.1946.iT.WEB Fantasia.1940.1990.iT.WEB |
I checked a few movies. If you scraped copyright instead of released year you'd get the correct year. Though not all movies have the copyright year. So maybe switch to copyright year and have released year as fallback, but even copyright year won't always be correct, e.g. But better that it's now with a lot of old movies having wrong year. |
Thanks for reporting. As for cases where the year in title and the release year on the metadata mismatch, it will remain as it currently is (like The original release year like (1941 in Dumbo's case) should be the correct one, but taking the release year from the title is problematic as it could be part of the title (for example: "2012" and "1917" are both movie names). Using the copyright is not reliable enough. I'll keep that in mind though and see if I can find a solution. |
How so? That it's available or accuracy? I've done 1.4k rips on the Swedish store. I'd say about 1/3-1/4 have incorrect year using released. A lot of them are off by 1-2 year (because of Swedish region released date) but a lot also have decades in difference. |
@MichaelYochpaz I checked a few more movies (Swedish store) and a lot them have released year one year later than copyright year. "Copyright year" is what IMDB, TMDB, Wikipedia have. IMO released year is what's not reliable. If you only look at the US store I guess you could say the few times it's incorrect makes it "unreliable". |
Confirmations
Description
If ripped individually the subtitles will always have a year in the title. Same for the subtitles in the ZIPs.
I think the ZIP files will only have year if the iTunes URL contains it. iTunes isn't consistent in having a year in URL for movies to avoid name collisions.
Example:
https://itunes.apple.com/se/movie/pinocchio/id540283464?l=en
https://itunes.apple.com/se/movie/pinocchio/id1597469980?l=en
The text was updated successfully, but these errors were encountered: