Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle intercom #974

Closed
kavinsky opened this issue Jul 5, 2015 · 25 comments
Closed

Vehicle intercom #974

kavinsky opened this issue Jul 5, 2015 · 25 comments
Assignees
Milestone

Comments

@kavinsky
Copy link
Collaborator

kavinsky commented Jul 5, 2015

Some vehicles like Helicopters have internal communication device to permit pilots/gunners/crewmans speak between.

https://www.youtube.com/watch?v=P06CXiEMob8

It should no need to use PPT to speak, and have radio effects on the voice.

@kavinsky kavinsky changed the title Vehicle interphone Vehicle intercom Jul 5, 2015
@michail-nikolaev michail-nikolaev added this to the 0.9.9 milestone Jul 6, 2015
@theYoursTruly
Copy link

Any update on this feature?

@michail-nikolaev
Copy link
Owner

Not yet :(

@Hailstorm12
Copy link

It has been a while since this was mentioned, would be good to see this become a part of the mod, would add a lot to vehicles, and make vehicle crews lives easier.

@kavinsky kavinsky modified the milestones: backlog, 0.9.9 Sep 19, 2016
@dedmen
Copy link
Collaborator

dedmen commented Sep 28, 2016

Theoretically we would just have to add a radio effect to direct speech and ignore the volume on distance calculation, if the other player is in the same vehicle and the vehicle supports intercom. We are already detecting if a player is in a vehicle and add the vehicleIsolation thingy onto players direct speech. So i think it wouldn't be a big problem to add that stuff.

@CorruptedHeart
Copy link
Collaborator

I don't think it was ever a huge problem to implement, just it will require time to setup the vehicles.

From my side, always a bit too nervous to touch too much in the TS plugin.

@dedmen
Copy link
Collaborator

dedmen commented Sep 28, 2016

Yeah... I understand not wanting to touch the TS plugin XD But my initial refactoring is done. Maybe about one week and then the Plugin is far enough to allow new features. (Besides I'm implementing a new feature right now)

@kavinsky
Copy link
Collaborator Author

we can play with the ACE hearing, since intercom its most of times used with protection headsets

@dedmen dedmen modified the milestones: 1.0.1, backlog Oct 11, 2016
@SlantX
Copy link

SlantX commented Oct 15, 2016

Just as a side note, our clan has ACE hearing disabled, since it doesn't really add to the gameplay. Would this work with ACE hearing disabled?

@dedmen
Copy link
Collaborator

dedmen commented Oct 15, 2016

@SlantX sure. We will probably just check if player has a headset with ACE_hearing. Doesn't matter if you enabled the ACE audio effects for that. Not even sure if we want to use that... As we can't have a dependency on ace anyway.

@kavinsky
Copy link
Collaborator Author

Maybe he is talking about not using at all the hearing pbo, since ACE its modular he can remove it.

@dedmen
Copy link
Collaborator

dedmen commented Nov 10, 2016

Intercom is kinda implemented. Though its very crappy right now. It's just forced by replacing direct voice with intercom when in vehicle.
It's in Pre-release 139

@dedmen dedmen modified the milestones: 1.0, 1.0.1 Nov 22, 2016
@dedmen dedmen self-assigned this Nov 22, 2016
@dedmen
Copy link
Collaborator

dedmen commented Nov 22, 2016

Intercom fully Implemented now. Can switch between Crew and Cargo channels via ACE Interaction menu. So Tank crew doesn't have to hear Cargo in a troop transporter. By default everyone is in Cargo channel.
The fully implemented system will be in Pre-release 144.
There may be some adjustments to the Intercom volume depending on peoples opinions in Beta testing. Intercom UI with Volume adjust is not planned. Maybe Clientside setting would be good.
Yeah... #DoThatDedmen

@BryanBoru
Copy link

are the Crew/Cargo channels dependant on which identified seats you have in the vehicle? Or can everyone get onto Crew from Cargo regardless of seat?
Also, this is tentatively implemented in both ground and air, correct?

@dedmen
Copy link
Collaborator

dedmen commented Nov 23, 2016

Everyone can switch to any channel. By using the imaginary intercom panel behind them.
Yep Its the same system for ground and air. But all Air vehicles have it. And not all ground vehicles do.

@dedmen
Copy link
Collaborator

dedmen commented Nov 23, 2016

Added config Settings to set Intercom volume clientside and disable Intercom serverside.

@dedmen dedmen closed this as completed Nov 23, 2016
@BryanBoru
Copy link

"all Air vehicles have it. And not all ground vehicles do"
That is preferable, especially compared to other way around. Thanks for reply.

@Saborknight
Copy link
Contributor

I know that this version of the intercom has been completed, and you have no idea how excited I am to hear this!
I was researching before this issue was worked on with the intention of contributing it to TFAR myself. Thank God @dedmen did it, it would have been my first time.
Anyway, the research may still be of some help if you were to further enhance this feature. Please refer to my Google doc: https://docs.google.com/document/d/1zXcXhawZ8-7SCj9aX8UCXeeAzI2khXrMU21d6fYfro4/edit?usp=drivesdk

The research is based off both secondary and primary data (a member in my unit served as a crew chief on a Chinook and continues in a civilian Chinook now).

If you have any questions about the research, I would suggest contacting me at support@saborknight.com .

@dedmen
Copy link
Collaborator

dedmen commented Dec 18, 2016

Thank you for that Information.. But besides being able to use the intercom system externally everything is already done like you wanted i think... Well seperate volume control for the channels is missing because we don't have any UI for the Intercom currently you can only hear people that are on the same channel as you are. And switching channels is only available in the ACE menu for the same reason. And we only have two channels (Crew, Cargo) for now.. could easilly be extended though.

@kavinsky
Copy link
Collaborator Author

Great document @Saborknight

@Saborknight
Copy link
Contributor

Saborknight commented Dec 19, 2016

Thanks @kavinsky !
Don't get me wrong, what you have now is excellent! Besides the moving about the vehicle part, you have a more simplified version which would probably work better since it simplifies the need to control the ICS unit. If the players have proper radio discipline then there shouldn't be too much need for any of the other features offered in real life.
However, maybe there could an implementation in the future of a sort of "Advanced intercom", similar to how ACE separated their medical system. Having emergency isolation switch would be awesome though, that's something I would personally want.
The only problem I can see with the current intercom implementation is that the player requires ACE to switch channels etc. Unless I am mistaken?

@kavinsky
Copy link
Collaborator Author

If you want to contribute a UI for the intercorm that would be great, atm im really fucked up with work and cant do anything, but if you want to start working on the ui i can give you some support on it.

@Saborknight
Copy link
Contributor

Alright. So how would that work then? Looking at the code it seems you're mapping interactable areas and then just adding and image in the background, is that right?

@kavinsky
Copy link
Collaborator Author

yes, you can use the in-game editor, the best way to start is loading up an existing radio into the editor and then modify. https://github.com/michail-nikolaev/task-force-arma-3-radio/blob/1.0/addons/handhelds/anprc152/ui/anprc152.ext#L1-L17

@kavinsky
Copy link
Collaborator Author

kavinsky commented Dec 19, 2016

Also look for a good frontal image of the ICS, and for real references, for russian and nato equipment if u want:)

@dedmen
Copy link
Collaborator

dedmen commented Dec 19, 2016

To set the intercom channel you can use this
(vehicle ACE_Player) setVariable [format ['TFAR_IntercomSlot_%1',(netID ACE_Player)],0,true];
the 0 at the end is the channel... you bascially have any number available you need... Don't remember right now how I'm storing it internally.. But atleast 255 channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants