Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimwiki Diary #12

Closed
folofjc opened this issue Jul 20, 2022 · 4 comments
Closed

Vimwiki Diary #12

folofjc opened this issue Jul 20, 2022 · 4 comments

Comments

@folofjc
Copy link

folofjc commented Jul 20, 2022

Since the command to add is simply git -C " . g:zettel_dir . " add . , it will only add files at the top level of the vimwiki. Vimwiki diaries by default live in the diary/ folder at the top level, and therefore do not get added. Would be great if this could be incorporated. It is an easy fix (probably including testing if a folder at diary_rel_path exists, then add everything in it. I can submit a PR if you want.

@michal-h21
Copy link
Owner

Nice idea! If you want to make a PR, I would be glad.

@folofjc
Copy link
Author

folofjc commented Jul 21, 2022

So I am not so sure that it doesn't work:/ It didn't at first, but then I opened it again and it looks like it did add them, but I don't know why, since they are not at the top level of g:zettel_dir. Can you check and see if it adds things in the diary/ directory?

@michal-h21
Copy link
Owner

I've just tried it, and it seems that the things in subdirectories are added.

@folofjc
Copy link
Author

folofjc commented Jul 21, 2022

Okay, then I'll close this. It was not working at first, I tried opening and closing vim and vimwiki multiple times and it did not add them. Based upon this link it seems to me like it should not add them. So not sure why it does, but I am glad that it does!

@folofjc folofjc closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants